Explore best practices for establishing and improving a code review culture in this 29-minute conference talk from SREcon19 Americas. Learn how organizations can intentionally build a sustainable code review process, discover techniques for code authors to communicate context effectively, and understand the key aspects reviewers should consider. Delve into topics such as sizing up pull requests, ensuring production readiness, and addressing language-specific concerns. Gain insights on maintaining high code quality, fostering team communication, and implementing effective patterns and practices through code review.
Overview
Syllabus
Creating a Code Review Culture Johnathan Turner Squarespace
Code review is useful
Code review provides
A code review culture is useful
Organizations
Be intentional about your culture
Code authors
Make the reviewer's life easier by communicating context
Code reviewers
Sizing up • What is the general shape of the PR? • Is the PR the right size?
Production readiness • How will we know when this breaks? • Is there new documentation required by this change? • Are there tests that prevent regression? • Is this change secure?
Language specific • Is the code well designed? • Is the code idiomatic to the language? • Are new patterns introduced? • Does the code fall into common pitfalls for the language?
Full checklist at
Taught by
USENIX
