Explore the nuances of effective code reviews in this JSConf Budapest 2017 talk by Vaidehi Joshi. Discover the ideal code review process through a creative retelling of Goldilocks' story, examining various review types and their impact on development teams. Learn about the history of code reviews, their importance in modern software development, and how to implement a balanced approach that fosters team collaboration and code quality. Gain insights from survey results and real-world experiences to understand common pitfalls and best practices. Uncover practical tips for improving your team's code review process, including commit hooks, PR templates, and strategies for developing empathy among team members. Embrace the power of collective ownership and effective communication to create a code review culture that enhances both individual skills and overall project success.
Overview
Syllabus
Introduction
Plot Summary
Goldilocks
Code Reviews
Second Dev Job
Small Team
One day
Panic attack
What did you do
Code Complete
Ideal Code Review Process
Team Code Review Process
Collective Ownership Of Construction
If Someone Leaves
Defect Correction
What are the different types of code reviews
The history of code reviews
What is a code review
Inspections
Short Reviews
Walkthroughs
Peerreview sophistication scale
Goldilocks and the three code reviews
Asking the internet
Disclaimer
Half Code Reviews Made You A Better Developer
Most People Felt Code Reviews Were A Good Thing
Most Engineering Teams Have Code Reviews
Team Requirements
Goldilocks Survey
Energy
Equal review
Large commits
Unequal reviews
Survey results
Negative reactions
Negative experiences
The disconnect
Modernday Goldilocks
Our Code Review Process
What Ive Learned
Commit Hooks
PR Templates
Screenshots
Encapsulation
Having specific reviewers
Collective ownership
Team culture
Developing empathy
Start a conversation
I love code reviews
Thank you
Taught by
JSConf
