Explore effective code review practices in this insightful conference talk from NDC Conferences. Learn why etiquette is crucial in code reviews and discover techniques to provide constructive feedback. Gain valuable insights on framing comments as questions rather than commands, including helpful links and explanations, and being mindful of review scope. Understand the importance of documenting offline conversations, using inclusive language, and reviewing the entire change. Delve into strategies for highlighting suggestions, taking time to provide thorough reviews, grouping similar feedback, and appreciating small improvements. Examine the benefits of pull request templates, managing pre/post PR tasks, and finalizing approval processes. Address toxic behaviors, separate personal identity from code, and master the art of asking the right questions. Enhance your code review skills to foster positive team dynamics and improve overall software quality.
Overview
Syllabus
Intro
Why is etiquette important?
Not an author review
Questions vs commands
Links to resources
Explanations
Review Scope Conscious
Documenting offline conversations
We vs You
Review the card
Calling out Suggestions
Io. Taking the time to do it right
II. Lump up similar suggestions
No suggestion is too small
Its a two way street
Appreciate!
Pull Request templates!
Pre/Post PR tasks
Finalizing the number of approvals
Code reviews take time too
Diffuse toxic behavior
You are NOT your code
Asking the right questions
Comment on your review
Self review
Taught by
NDC Conferences
